Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable libraw flip #1301

Merged
merged 8 commits into from
Jun 12, 2023
Merged

Disable libraw flip #1301

merged 8 commits into from
Jun 12, 2023

Conversation

servantftechnicolor
Copy link
Contributor

Make sure libraw does not reorient our buffer.

A PR is under review at OiiO to give back the flip value even if its application is disabled.

AcademySoftwareFoundation/OpenImageIO#3669

@fabiencastan fabiencastan added this to the 2.5.0 milestone Jan 3, 2023
@mugulmd
Copy link
Contributor

mugulmd commented Jan 31, 2023

Tested with OpenImageIO 2.4.7.0 (contains fix AcademySoftwareFoundation/OpenImageIO#3669) and RAW images with raw:flip metadata set to 5.
Results:

  • without this PR: buffers are rotated (in my case dimensions should be 6744x4502 but they are 4502x6744) and Orientation metadata is 1
  • with this PR: buffers are not rotated and Orientation metadata is 5.

Note: there is no need to make a PR in QtAliceVision to report the changes proposed in QtOIIO (cf . alicevision/QtOIIO#26) since QtAliceVision directly calls aliceVision::image::readImage and the bug with orientations 5 and 7 has already been fixed

@mugulmd
Copy link
Contributor

mugulmd commented Feb 14, 2023

Tried to create a panorama with this branch using images with flip tag 5:
there is an orientation problem when merging the different viewpoints, which leads to incoherent results.

This orientation problem is already visible at the PanoramaWarping stage, but it may already be present in the previous stages.

@fabiencastan fabiencastan modified the milestones: 3.0.0, 3.0.1 Mar 11, 2023
@fabiencastan fabiencastan modified the milestones: 3.2.0, 3.1.0 Apr 3, 2023
@demoulinv demoulinv force-pushed the dev/rawDisableFlip branch 2 times, most recently from 060ce0e to 72c665f Compare June 5, 2023 12:20
@mugulmd mugulmd force-pushed the dev/rawDisableFlip branch 2 times, most recently from 49dc84b to 989e608 Compare June 8, 2023 13:49
@mugulmd mugulmd force-pushed the dev/rawDisableFlip branch from 989e608 to 5fe182b Compare June 12, 2023 07:34
@mugulmd mugulmd merged commit 634ac12 into develop Jun 12, 2023
@mugulmd mugulmd deleted the dev/rawDisableFlip branch June 12, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants