-
-
Notifications
You must be signed in to change notification settings - Fork 829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[software] fix split dual fisheye #1378
Conversation
Although it was not introduced by this PR, i don't understand why the input and outputs are folders instead of sfmData. This make this application difficult to pipeline with the other apps. |
Yes, it would be great to also generate an sfmData as suggested by @servantftechnicolor in another PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same rig folder structure should also be used in the case of equirectangular split (not only dual-fisheye).
For another PR: when the input is a folder, we list all files and it would be good to check that the file extension is a supported image file. |
Description
The
dualfisheye
split mode of thealiceVision_split360Images
software is currently broken, as it only saves on disk two fully black images.This problem seems to be related to the use of oiio image buffers for copying data.
In this PR, we replace the previous approach with a simpler one: since images are eigen matrices, we copy the blocks we need from the source image and save them, hence there is no need to use oiio at any point.
Notes
Some extra modifications have been made to the
aliceVision_split360Images
software:These changes of the command-line and output folder structure have 2 side-effects:
Meshroom PR: alicevision/Meshroom#1935