Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[software] fix split dual fisheye #1378

Merged
merged 7 commits into from
Mar 15, 2023
Merged

Conversation

mugulmd
Copy link
Contributor

@mugulmd mugulmd commented Mar 13, 2023

Description

The dualfisheye split mode of the aliceVision_split360Images software is currently broken, as it only saves on disk two fully black images.
This problem seems to be related to the use of oiio image buffers for copying data.

In this PR, we replace the previous approach with a simpler one: since images are eigen matrices, we copy the blocks we need from the source image and save them, hence there is no need to use oiio at any point.

Notes

Some extra modifications have been made to the aliceVision_split360Images software:

  • the extracted images are saved on disk using a rig structure
  • the "demo" mode has been renamed to "preview" mode
  • the user can now specify the output image extension

These changes of the command-line and output folder structure have 2 side-effects:

  • software version went from 1.0 to 2.0
  • changes must be reflected in the corresponding Meshroom node.

Meshroom PR: alicevision/Meshroom#1935

@mugulmd mugulmd requested a review from fabiencastan March 13, 2023 16:14
@mugulmd mugulmd self-assigned this Mar 13, 2023
@servantftechnicolor
Copy link
Contributor

Although it was not introduced by this PR, i don't understand why the input and outputs are folders instead of sfmData. This make this application difficult to pipeline with the other apps.

@fabiencastan fabiencastan added this to the 3.0.0 milestone Mar 14, 2023
@fabiencastan
Copy link
Member

Yes, it would be great to also generate an sfmData as suggested by @servantftechnicolor in another PR.

Copy link
Member

@fabiencastan fabiencastan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same rig folder structure should also be used in the case of equirectangular split (not only dual-fisheye).

@mugulmd mugulmd marked this pull request as draft March 15, 2023 09:57
@fabiencastan
Copy link
Member

For another PR: when the input is a folder, we list all files and it would be good to check that the file extension is a supported image file.

@fabiencastan fabiencastan merged commit e7882c3 into develop Mar 15, 2023
@fabiencastan fabiencastan deleted the mug/fix/splitDualFisheye branch March 15, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants