[panoramaInit] add generation of contact sheet using xml input #1392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbentejac
force-pushed
the
dev/contactSheet
branch
from
e3ee2cb to
36026e3
Compare
cbentejac
previously approved these changes
Mar 29, 2023
There was a problem hiding this comment.
All good to me! I tried all the possible combinations on several datasets and it worked as expected every time.
I rebased the PR on top of develop and pushed two additional commits: one that adds constness where possible and renames some variables to fit in with rest, and one that clang-formatted the whole file.
The contact sheet is not built unless the argument for it is specified.
cbentejac
force-pushed
the
dev/contactSheet
branch
from
83fe706 to
06774e1
Compare
cbentejac
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add algorithms in panoramaInit to enable contact sheet generation.
The contact sheet is then generated if an XML file is present to initialize the camera poses.
The contact sheet is some preview of the panorama using the inputs.
alicevision/Meshroom#1945