SfM: Expose new parameters to the command line #1413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/aliceVision/sfm/pipeline/sequential/ReconstructionEngine_sequentialSfM.hpp
Outdated
Show resolved
Hide resolved
src/aliceVision/sfm/pipeline/sequential/ReconstructionEngine_sequentialSfM.hpp
Outdated
Show resolved
Hide resolved
src/aliceVision/sfm/pipeline/sequential/ReconstructionEngine_sequentialSfM.cpp
Outdated
Show resolved
Hide resolved
cbentejac
force-pushed
the
dev/sfmExposeParams
branch
from
e7c36c4 to
a6f3cec
Compare
src/aliceVision/sfm/pipeline/sequential/ReconstructionEngine_sequentialSfM.cpp
Outdated
Show resolved
Hide resolved
`nbFirstUnstableCameras` and `maxImagesPerGroup` were hard-coded variables set in the "findNextBestView" function which could not be modified in any way. They are now part of the `Params` structure and can thus be modified.
The `nbFirstUnstableCameras` and `maxImagesPerGroup` parameters, which respectively set the number of cameras for which the bundle adjustment is performed every time a camera is added and the maximum number of cameras that can be added before a new bundle adjustment has to be performed, are now exposed in the command line.
The logs are useful to determine whether all the provided folders are correctly loaded.
cbentejac
force-pushed
the
dev/sfmExposeParams
branch
from
a6f3cec to
3ef258c
Compare
fabiencastan
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR exposes two previously hard-coded parameters to the Incremental Structure From Motion command line:
nbFirstUnstableCameras, which sets the number of cameras for which the bundle adjustment is performed every time a new camera is added. PastnbFirstUnstableCamerascameras, the bundle adjustment is only performed once every N cameras, with N up tomaxImagesPerGroup;maxImagesPerGroup, which sets the maximum number of cameras that can be added before the bundle adjustment has to be performed again.Additionally, debug logs have been added to monitor the feature and match folders that are provided, and those that are actually loaded.
Related pull request in Meshroom: alicevision/Meshroom#1980