Build: Add dependency to Boost.JSON and make the Calibration module Boost1.81-compliant #1416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiencastan
previously approved these changes
Apr 17, 2023
Following the merge of #1331, the `boost-json` module is needed and thus needs to be installed along all the other Boost modules.
Using std::vectors directly in the constructor of boost::json::value raises C2440 errors with Boost 1.81, as initializer lists cannot directly be converted to boost::json::value. The conversion needs to be explicit.
cbentejac
force-pushed
the
build/boostJson
branch
from
73fa475 to
f68acd6
Compare
mugulmd
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following the merge of #1331, a dependency to Boost.JSON has been added.
As a consequence, this PR:
boost-jsonto the list of packages to install with vcpkg;