[image] ImageCache improvements #1419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mugulmd
force-pushed
the
mug/imageCaching/improvements1
branch
from
10cf378 to
b9ec481
Compare
mugulmd
force-pushed
the
mug/imageCaching/improvements1
branch
from
b9ec481 to
2062ca7
Compare
fabiencastan
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The goal of this PR is to refine the image caching system previously introduces by adding new functionnalities and improving code quality.
Features list
containsmethod for checking if a given image is in the cache (without affecting LRU ordering)cachedOnlyflag to retrieve an image only if it is in the cache (i.e no image will be loaded from disk)lazyCleaningflag to enable/disable lazy cleaning (= cleaning large images in priority instead of respecting LRU ordering)missingCapacitycomputation