IncrementalSfM: expose nbOutliersThreshold param #1436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/aliceVision/sfm/pipeline/sequential/ReconstructionEngine_sequentialSfM.hpp
Outdated
Show resolved
Hide resolved
|
Add support for -1 to completely disable BA iterations: |
mugulmd
force-pushed
the
mug/exposeNbOutliersThreshold
branch
from
0b2a7eb to
fbd9ad7
Compare
Done |
src/aliceVision/sfm/pipeline/sequential/ReconstructionEngine_sequentialSfM.cpp
Outdated
Show resolved
Hide resolved
cbentejac
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The goal of this PR is to expose an internal variable used in the sequential SfM reconstruction engine called
nbOutliersThreshold.This variable is now accessible through the parameters of the reconstruction engine and the incremental SfM command line.