Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve a set of bugs on cameraInit #1726

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Solve a set of bugs on cameraInit #1726

merged 2 commits into from
Jul 17, 2024

Conversation

servantftechnicolor
Copy link
Contributor

Updates to camera init :

  • when no information available, sensorwidth was set to 36 and sensorHeight was set to 24 not considering the image ratio
  • The effect of pixel aspect ratio on "focal length" (scale) is updated
  • The default offset is assigned even if no valid focal length is known
  • Initial focal length was enforced during sfm even if the sensor width was only guessed

@cbentejac cbentejac added this to the 3.3.0 milestone Jul 17, 2024
@cbentejac cbentejac merged commit c870b2c into develop Jul 17, 2024
3 of 4 checks passed
@cbentejac cbentejac deleted the dev/cameraInit branch July 17, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants