[image] Fix erroneous color space detection for images that contain "raw" in their filepath #1728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbentejac
force-pushed
the
bugfix/colorspaceDetection
branch
from
784930d
to
517cdbf
Compare
cbentejac
approved these changes
Jul 22, 2024
cbentejac
changed the title
cbentejac
changed the title
cbentejac
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the following bug:
For non raw images (for instance jpeg format), without any color space indication in the metadata, if the image filepath contains "raw" then the Raw color space is detected by the ocio function using the filepath as a hint to guess the color space.
Because no conversion is defined in the ocio.config file from the raw color space the image reading fails.
Features list
Implementation remarks