Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[software] Texturing Add support for UDIM UV mapping #596

Merged
merged 3 commits into from
Mar 1, 2019
Merged

Conversation

gregoire-dl
Copy link
Member

No description provided.

@@ -88,6 +88,7 @@ struct Texturing
StaticVector<Voxel> trisNormalsIds;
PointsVisibility* pointsVisibilities = nullptr;
Mesh* me = nullptr;
bool useUDIM = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use same default value

@@ -46,6 +46,7 @@ int main(int argc, char* argv[])
std::string imagesFolder;
std::string outTextureFileTypeName = EImageFileType_enumToString(EImageFileType::PNG);
bool flipNormals = false;
bool useUDIM = true;
mesh::TexturingParams texParams;
std::string unwrapMethod = mesh::EUnwrapMethod_enumToString(mesh::EUnwrapMethod::Basic);
std::string visibilityRemappingMethod = mesh::EVisibilityRemappingMethod_enumToString(texParams.visibilityRemappingMethod);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Directly use an enum for visibilityRemappingMethod.

@@ -46,6 +46,7 @@ int main(int argc, char* argv[])
std::string imagesFolder;
std::string outTextureFileTypeName = EImageFileType_enumToString(EImageFileType::PNG);
bool flipNormals = false;
bool useUDIM = true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useUDIM could be part of texParams

@fabiencastan fabiencastan merged commit ecbcd87 into develop Mar 1, 2019
@fabiencastan fabiencastan deleted the dev_UDIM branch March 1, 2019 21:57
@fabiencastan fabiencastan added this to the 2019.X milestone Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants