-
-
Notifications
You must be signed in to change notification settings - Fork 829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[software] Texturing
Add support for UDIM UV mapping
#596
Conversation
src/aliceVision/mesh/Texturing.hpp
Outdated
@@ -88,6 +88,7 @@ struct Texturing | |||
StaticVector<Voxel> trisNormalsIds; | |||
PointsVisibility* pointsVisibilities = nullptr; | |||
Mesh* me = nullptr; | |||
bool useUDIM = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use same default value
@@ -46,6 +46,7 @@ int main(int argc, char* argv[]) | |||
std::string imagesFolder; | |||
std::string outTextureFileTypeName = EImageFileType_enumToString(EImageFileType::PNG); | |||
bool flipNormals = false; | |||
bool useUDIM = true; | |||
mesh::TexturingParams texParams; | |||
std::string unwrapMethod = mesh::EUnwrapMethod_enumToString(mesh::EUnwrapMethod::Basic); | |||
std::string visibilityRemappingMethod = mesh::EVisibilityRemappingMethod_enumToString(texParams.visibilityRemappingMethod); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Directly use an enum for visibilityRemappingMethod
.
@@ -46,6 +46,7 @@ int main(int argc, char* argv[]) | |||
std::string imagesFolder; | |||
std::string outTextureFileTypeName = EImageFileType_enumToString(EImageFileType::PNG); | |||
bool flipNormals = false; | |||
bool useUDIM = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
useUDIM
could be part of texParams
No description provided.