[Texturing] Add option to correct exposure values during Texturing #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- some refactoring + remove "bandType" parameter - add notion of exposure correction in ImagesCache constructor & necessary functions
Exposure correction must be done in linear colorspace -> add function to convert image colorspace with OIIO
cvere
force-pushed
the
dev_EVcorrect_Texturing
branch
2 times, most recently
from
38c528b to
55221de
Compare
check if the exposure compensation factor has been calculated & stocked in metadatas during PrepareDenseScene
Move imageIO::colorconvert to imageAlgo + some refactoring
fabiencastan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add an option to correct exposure values (EV) of input images during texturing, to uniformize dataset exposures.
Do exactly the same thing than #652, but during Texturing instead of PrepareDenseScene
Features list
Implementation remarks
Exposure correction must be applied in Linear colorspace while texturing must be done in sRGB colorspace. Thus, when loading images for texturing with exposure compensation, we read images in Linear colorspace, correct their exposure and then we convert them in sRGB.