Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vertex-colored meshes #661

Merged
merged 11 commits into from
Jul 16, 2019
Merged

Vertex-colored meshes #661

merged 11 commits into from
Jul 16, 2019

Conversation

yann-lty
Copy link
Member

@yann-lty yann-lty commented Jul 10, 2019 •
edited
Loading

Description

This PR adds vertex color data in Mesh class, with OBJ file format IO support. Regarding software, vertex colors are written in Meshing step's output OBJ file and correctly preserved during MeshFiltering.

Features list

  • [mesh] IO: read/write vertex colors from/to OBJ files
  • [software] Meshing: write vertex colors in output OBJ file
  • [mesh] preserve vertex color data in MeshClean::cleanMesh
  • [software] MeshFiltering: clear free points from mesh after cleaning operations
  • Make mesh output coloring optional

Implementation remarks

Vertex colors are written as 3 additional floats per vertex line in OBJ files. It is not part of the official OBJ file format description but it is supported by several software.

From: https://en.wikipedia.org/wiki/Wavefront_.obj_file#Geometric_vertex

A vertex can be specified in a line starting with the letter v. That is followed by (x,y,z[,w]) coordinates. W is optional and defaults to 1.0. Some applications support vertex colors, by putting red, green and blue values after x y and z. The color values range from 0 to 1.

yann-lty added 5 commits July 10, 2019 16:23
@yann-lty
[mesh] rename 'colors' variable to 'colorLabels' in member function
4b8640a 
avoid confusions with 'colors' member variable that will be introduced in next commits
@yann-lty
[mesh] add support for vertex color data
b4b1b7e 
* IO: read/write colors from/to OBJ file format
* clean: remove unused transformGlobal member variable
@yann-lty
[mesh] refactor Mesh.addMesh method + handle vertex color data
6a7ce41 
* simplify addMesh method code
* copy colors data from input mesh if any
@yann-lty
[mesh] update vertex color data in MeshClean::cleanMesh
68c1a17 
remap vertex colors to reflect changes in mesh topology after the cleaning operation
@yann-lty
[software][meshing] save vertex colors in output OBJ file
a99cf3c
@yann-lty yann-lty mentioned this pull request Jul 10, 2019
Merged
yann-lty added 3 commits July 10, 2019 17:42
@yann-lty
[mesh] delete "colors" in Mesh destructor
e49524b
@yann-lty
[mesh] colors: replace StaticVector* by std::vector
f79a12c 
Previous version was mostly to keep things close to legacy code, but it seems better to write new code as we intend to.
@yann-lty
[software] Meshing: add "colorizeOutput" option
c7dcf12 
Make the colorization of output dense point cloud and mesh optional.
@yann-lty yann-lty requested review from fabiencastan and cvere July 12, 2019 08:03
@yann-lty yann-lty added this to the 2019.2 milestone Jul 12, 2019
@yann-lty
[software] Meshing: simplify colorization + factorize code
fdba88d 
* split `exportPointCloud` into createDenseSfMData / `removeLandmarksWithoutObservations`
* colorize mesh before landmark filtering to avoid having indices mapping
* factorize output result writing code for all methods
@fabiencastan fabiencastan merged commit 8cfb63b into develop Jul 16, 2019
@fabiencastan fabiencastan deleted the dev/coloredMesh branch July 16, 2019 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabiencastan fabiencastan Awaiting requested review from fabiencastan

@cvere cvere Awaiting requested review from cvere

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2019.2
Development

Successfully merging this pull request may close these issues.
2 participants
@yann-lty @fabiencastan