New hdri stitching software #678

ToukL · 2019-08-07T13:56:38Z

Description

Stitch fisheye images into 360° panorama with simple geometric transformations, without undistortion or feature matching.

Features list

Take a folder or a list of fisheye images and return a 360° panorama image file.
Project fisheye into equirectangular space.
Stitch all images together with an "over" merge operation (Aa + B(1-a)).
User can correct each image rotation on all axes.

All channels need to be set to zero including alpha for RGBA colors

simogasp · 2019-08-08T16:19:49Z

src/aliceVision/image/io.cpp

+  for(const std::string& format: supportedFormat)
+  {
+    std::vector<std::string> extensions;
+    std::string str = format.substr(format.find(":")+1);


simogasp · 2019-08-08T16:21:38Z

src/software/utils/main_fisheyeProjection.cpp

@@ -93,7 +93,7 @@ float sigmoid(float x, float sigwidth, float sigMid)
 * @param[out] buffer - to store input metadata in output image
 * @param[out] imageAlpha - output RGBAf fisheye image correctly oriented
 */
-void setFisheyeImage(image::Image<image::RGBfColor>& imageIn, oiio::ImageBuf& buffer, image::Image<image::RGBAfColor>& imageAlpha)
+void setFisheyeImage(image::Image<image::RGBfColor>& imageIn, const float blurWidth_param, oiio::ImageBuf& buffer, image::Image<image::RGBAfColor>& imageAlpha)


const not necessary with primitive type

simogasp · 2019-08-08T16:21:56Z

src/software/utils/main_fisheyeProjection.cpp

-  const float maxRadius = std::min(width, height) * 0.5 * 0.95;
-  const float blurWidth = maxRadius * 0.2;
-  const float blurMid = maxRadius * 0.95;
+  const float maxRadius = std::min(width, height) * 0.5;


simogasp · 2019-08-08T16:23:12Z

src/software/utils/main_fisheyeProjection.cpp

@@ -188,7 +188,7 @@ void fisheyeToEquirectangular(image::Image<image::RGBAfColor>& imageIn, const in
 * @param[in] rotations - contains adjustment rotations on each image set by user
 * @param[out] outputFolder - output folder path to write panorama
 */
-void stitchPanorama(const std::vector<std::string>& imagePaths, const std::vector<oiio::ParamValueList>& metadatas, const std::array<std::vector<double>, 3> rotations, std::string& outputPath)
+void stitchPanorama(const std::vector<std::string>& imagePaths, const std::vector<oiio::ParamValueList>& metadatas, const float blurWidth, const std::array<std::vector<double>, 3> rotations, std::string& outputPath)


no const for float

missing & for rotations

simogasp · 2019-08-08T16:25:13Z

src/aliceVision/image/pixelTypes.hpp

@@ -362,7 +370,11 @@ namespace aliceVision
                     T( ( Z )( *this )( 3 ) * val ) );
      }
    };
+
+    /// Instantiation for unsigned char color component


using RGBAColor = Rgba<unsigned char>

simogasp · 2019-08-08T16:46:45Z

src/software/utils/main_fisheyeProjection.cpp

+    {
+      imagePaths.push_back(path.string());
+
+      oiio::ParamValueList metadata = image::readImageMetadata(entry);


simogasp · 2019-08-08T16:48:51Z

src/software/utils/main_fisheyeProjection.cpp

+      boost::smatch what;
+      if(boost::regex_search(dateTime, what, dateTimeExp))
+      {
+          times.push_back(24.0 * std::stof(what["h"]) + 60.0 * std::stof(what["m"]) + std::stof(what["s"]));


since this part is repeated here and in the previous if branch, maybe consider to refactor it into a function. the only difference is that here you are doing something with a single file, in the previous one you are doing the exact same thing for each file in the directory

simogasp · 2019-08-08T16:49:20Z

src/software/utils/main_fisheyeProjection.cpp

+    return EXIT_FAILURE;
+  }
+
+  int nbImages = imagePaths.size();


simogasp · 2019-08-08T16:49:53Z

src/software/utils/main_fisheyeProjection.cpp

+
+  // sort images according to their metadata "DateTime"
+  std::sort(times_sorted.begin(), times_sorted.end());
+  for(int i=0; i<nbImages; ++i)


std::size_t i

simogasp · 2019-08-08T16:50:08Z

src/software/utils/main_fisheyeProjection.cpp

+    std::vector<float>::iterator it = std::find(times.begin(), times.end(), times_sorted[i]);
+    if(it != times.end())
+    {
+      std::size_t index = std::distance(times.begin(), it);


…liceVisionPrivate into dev_hdri_stitching

In fact, it doesn't really make sense to add weighting in the BA context.

…onPrivate into dev_hdri_stitching

…utput is exr)

Also supports value 0 for automatic detection of the number of brackets.

…ize in metadata

src/software/pipeline/main_panoramaExternalInfo.cpp

…liceVisionPrivate into dev_hdri_stitching

…y and minor code simplification

ToukL and others added 16 commits July 25, 2019 11:51

[software] New software for stithing fisheye images in 360° panorama

8f4a0b0

[cmake] add ILMBASE_INCLUDE_PATH to FindOpenImageIO

737ed20

[image] add instantiation for float RGBA pixel type

d21c101

[image] add RGBA default constructor with all channels set to zero

5077007

[image][Sampler] bug fix : call to default constructor

bdd2b91

All channels need to be set to zero including alpha for RGBA colors

[software] add doxygen doc

c7e842c

[software] modify default rotation angles

4f733fa

[software] add option to give complete output path insted of folder

b4c5454

Merge branch 'develop' into dev_hdri_stitching

110be8d

[software] stitching: move buffer initialization

6a02f93

[software] stitching: bug fix on buffer copy

e577670

[software] stitching: change log info description

0d76793

[imageIO] add isSuported function to check input image extension

4e49836

[software] stitchin: add log error message

0c69255

[software] stitching: get only valid image files from input folder

363a664

[software] stitching: add parameter to adjust blur width in alpha mask

670b54d

simogasp requested changes Aug 8, 2019

View reviewed changes

simogasp added the feature label Aug 8, 2019

simogasp added this to the 2019.3 milestone Aug 8, 2019

ToukL added 11 commits August 9, 2019 18:15

[image] pixelTypes: replace all typedef by using

9cf0d1d

[imageIO] add const

25cffd4

[software] Stitching: add or remove const and clean code

b2aec22

[software] Stitching: change class SphericalMaping to namespace

78b8041

[software] Stitching: add function to sort images by time

0e03fc1

[globalSfM] Add enum methods for rotations and translations

8edd995

[sfm] Add panorama reconstruction engine based on global sfm

6de58b6

[software] New software for stitching panorama with feature matching

237b542

[globalSfM] Add max_angular_error for triplet rotation rejection

bb929c1

[sfm] Add log infos

be120eb

[panorama] remove aliceVision namespace

9cdfb96

servantftechnicolor and others added 19 commits December 10, 2019 15:41

memory reduction

0a6d674

Merge branch 'dev_hdri_stitching' of https://github.com/alicevision/A…

5096d47

…liceVisionPrivate into dev_hdri_stitching

add offsets to rotation for panorama

d967fb8

add bypass to HDR

900def1

some correction on alpha blending

e5c8877

[hdr] laguerre: remove weighting

c23879a

In fact, it doesn't really make sense to add weighting in the BA context.

[build] Eigen compatibility: use Matrix instead of Vector

0002d13

Merge branch 'dev_hdri_stitching' of github.com:alicevision/AliceVisi…

339fcb5

…onPrivate into dev_hdri_stitching

[software] LdrToHdr: rename parameters for highlight postprocessing

cbb3e86

[software] LdrToHdr: remove export of debug files

38e469a

[software] panoramaWarping: export images in AUTO (no impact as the o…

2aff5ae

…utput is exr)

Hack to make things work for laplacian on borders ...

a712450

[hdri] laguerre: fix incorrect Laguerre formula

12689a1

[nodes] LDRToHDR: rename param to nbBrackets

a8fdf6f

Also supports value 0 for automatic detection of the number of brackets.

[sfmDataIO] disable resize heuristic as RAW images have a different s…

c274b68

…ize in metadata

Add option for compositer Type

414ef86

compute seams globally and not iteratively

df44721

forgot a debug output

b41730d

remove user file

587aacf

fabiencastan reviewed Dec 16, 2019

View reviewed changes

src/software/pipeline/main_panoramaExternalInfo.cpp Outdated Show resolved Hide resolved

fabiencastan and others added 8 commits December 16, 2019 19:37

[software] panoramaExternalInfo: update log

2e7d7ac

Change upscale function

c0cd659

numerical problem for bounding box when we exactly cross the loop

ba8082b

add loop on upscale gaussian

420d74f

Merge branch 'dev_hdri_stitching' of https://github.com/alicevision/A…

a0a1d64

…liceVisionPrivate into dev_hdri_stitching

[software] PanoramaWarping: fix potential out-of-range access to arra…

0698c38

…y and minor code simplification

[image] RGBA constructor: avoid auto alpha

66a2bec

minor code clean

790af00

fabiencastan merged commit 37ead81 into develop Jan 14, 2020

fabiencastan deleted the dev_hdri_stitching branch January 14, 2020 15:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New hdri stitching software #678

New hdri stitching software #678

ToukL commented Aug 7, 2019

simogasp Aug 8, 2019

simogasp Aug 8, 2019

simogasp Aug 8, 2019

simogasp Aug 8, 2019

simogasp Aug 8, 2019

simogasp Aug 8, 2019

simogasp Aug 8, 2019

simogasp Aug 8, 2019

simogasp Aug 8, 2019

simogasp Aug 8, 2019

New hdri stitching software #678

New hdri stitching software #678

Conversation

ToukL commented Aug 7, 2019

Description

Features list

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment