Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scale as parameter in functions for sfm #736

Merged
merged 5 commits into from
Mar 25, 2020
Merged

Conversation

theoleplomb
Copy link

@theoleplomb theoleplomb commented Feb 4, 2020

Description

Add scale as parameter in functions for sfm.
Single PointFeature class with scale and orientation.

Features list

[X] SfM: Add observationConstraint param to choose between:

  • Basic: use standard reprojection error in pixel coordinates
  • Scale: use reprojection in pixel coordinates relative to the features scale

@fabiencastan fabiencastan force-pushed the dev/featureScale branch 2 times, most recently from 4e01849 to 884a3f6 Compare March 19, 2020 16:57
* fix feature index in multiview triangulate
* fix removeOutliers for observations without scale
@fabiencastan fabiencastan merged commit b0bd9d6 into develop Mar 25, 2020
@fabiencastan fabiencastan deleted the dev/featureScale branch March 25, 2020 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants