Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[image] Fix bug with input RGBA Images #743

Merged
merged 1 commit into from
Feb 26, 2020
Merged

Conversation

gregoire-dl
Copy link
Member

Description

Fix bug with input RGBA Images.
Alpha channel was erased on image reading.

Alpha channel was erased on image reading
oiio::ImageBuf requestedBuf(requestedSpec);
int channelOrder[] = { 0, 0, 0 };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const

oiio::ImageBuf requestedBuf(requestedSpec);
int channelOrder[] = { 0, 0, 0 };
float channelValues[] = { 0 /*ignore*/, 0 /*ignore*/, 0 /*ignore*/ };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const

Comment on lines +301 to +302
int channelOrder[] = { 0, 1, 2, -1 /*constant value*/ };
float channelValues[] = { 0 /*ignore*/, 0 /*ignore*/, 0 /*ignore*/, 1.0 };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const

@fabiencastan fabiencastan merged commit f4bc953 into develop Feb 26, 2020
@fabiencastan fabiencastan deleted the dev_fixImageRGBA branch February 26, 2020 21:01
Totorro35 added a commit to checkandvisit/AliceVision that referenced this pull request Mar 4, 2020
@natowi natowi added this to the 2020.1.0 milestone Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants