Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid circular dependency #839

Merged
merged 7 commits into from
Jul 28, 2020
Merged

Avoid circular dependency #839

merged 7 commits into from
Jul 28, 2020

Conversation

fabiencastan
Copy link
Member

Features list

  • Avoid circular dependency between "feature" and "sfmData"
    Move one function from "feature" to "sfm".
  • Check Eigen defines
  • Build fix for MSVC 2015/2017

@fabiencastan fabiencastan added this to the 2020.1.0 milestone Jul 24, 2020
@fabiencastan fabiencastan requested a review from simogasp July 24, 2020 16:10
simogasp
simogasp requested changes Jul 24, 2020
View reviewed changes
Copy link
Member

@simogasp simogasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of changes and a proposition

src/aliceVision/sfm/matchesFiltering.cpp Outdated Show resolved Hide resolved
src/aliceVision/sfmData/SfMData.cpp Show resolved Hide resolved
src/aliceVision/sfmData/SfMData.cpp Show resolved Hide resolved
@fabiencastan fabiencastan mentioned this pull request Jul 27, 2020
Merged
@fabiencastan fabiencastan merged commit b933509 into develop Jul 28, 2020
@fabiencastan fabiencastan deleted the dev/codeStructure branch July 28, 2020 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simogasp simogasp simogasp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@fabiencastan @simogasp