[matching] implement cross check for feature matching #980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
ghost
mentioned this pull request
pmoulon
reviewed
Feb 13, 2021
| matcherCross.Match(_f_dist_ratio, regionsI, vec_putatives_matches_cross); | ||
|
|
||
| //Create a dictionnary of matches indexed by their pair of indexes | ||
| std::map<std::pair<int, int>, IndMatch> check_matches; |
There was a problem hiding this comment.
You could use existing code for this. See here https://github.com/alicevision/AliceVision/blob/develop/src/aliceVision/matching/filters.hpp. Symmetric matches filtering
There was a problem hiding this comment.
- This function requires multiple conversions before input, and after output.
- It requires to build 3 vectors the size of the features sets even if the amount of matches is very low
There was a problem hiding this comment.
I did not look into the details but the ability to use nndistanceratio or symmetric or combine both may be interesting to expose.
fabiencastan
approved these changes
Feb 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add cross check for feature matching :
For an image pair (I, J).
If a keypoint a in I match to a keypoint b in J, then this match is accepted if and only if keyboint b in J match to keypoint a in I.