Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cmake] Use modern cmake to manage OpenGV #994

Merged
merged 2 commits into from
Feb 24, 2021
Merged

[cmake] Use modern cmake to manage OpenGV #994

merged 2 commits into from
Feb 24, 2021

Conversation

simogasp
Copy link
Member

Use the imported target to manage the dependency

note: opengv does not export the target with a namespace... (it's a bug, my bad..)

fixes #989 #990

@simogasp
[cmake] manage opengv dependency with modern cmake
d38ee5f 
* use imported target
* update av config file to look for the
dependency
* remove the findOpenGV
@simogasp
[cmake] fix typo
f23f179
@simogasp simogasp added this to the 2.4.0 milestone Feb 20, 2021
@simogasp simogasp linked an issue Feb 20, 2021 that may be closed by this pull request
'FIND_PACKAGE(Eigen QUIET)' should be 'FIND_PACKAGE(Eigen3 QUIET)' #990
Closed
@fabiencastan fabiencastan merged commit 47fef5a into develop Feb 24, 2021
@fabiencastan fabiencastan deleted the cmake/opengvModern branch February 24, 2021 21:19
@simogasp simogasp mentioned this pull request May 1, 2022
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabiencastan fabiencastan fabiencastan approved these changes

Assignees
No one assigned
Labels
scope:build
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.

'FIND_PACKAGE(Eigen QUIET)' should be 'FIND_PACKAGE(Eigen3 QUIET)' Fails to find OpenGV include path
2 participants
@simogasp @fabiencastan