Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] keyboard shortcut: press tab to open node menu #1813

Merged
merged 3 commits into from
Nov 8, 2022

Conversation

mugulmd
Copy link
Contributor

@mugulmd mugulmd commented Nov 2, 2022

Description

This PR introduces a new keyboard shortcut in the graph editor: TAB to open the node menu (same behavior as right clicking).

This has been requested by a user, the main reason being that this shortcut is used in several other programs (Houdini, Maya, Nuke, etc.).

@mugulmd mugulmd self-assigned this Nov 2, 2022
Copy link
Contributor

@cbentejac cbentejac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, when you create a node after opening the menu with tab instead of right-click, the node is successfully created and appears to be selected (it is highlighted in blue as expected) but it doesn't respond to any keyboard shortcut (you can't delete it with "suppr" or duplicate it with "D" whereas you can when the menu is opened through the right-click).

You need to unselect and then reselect the node for the keyboard shortcuts to be effective on that node.

@fabiencastan fabiencastan added this to the Meshroom 2022.1.0 milestone Nov 8, 2022
@fabiencastan fabiencastan merged commit c4d44aa into develop Nov 8, 2022
@fabiencastan fabiencastan deleted the mug/tabOpenNodeMenu branch November 8, 2022 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants