Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ui] Viewer2D: fix minor issues #1829

Merged
merged 3 commits into from
Nov 30, 2022
Merged

[ui] Viewer2D: fix minor issues #1829

merged 3 commits into from
Nov 30, 2022

Conversation

cbentejac
Copy link
Contributor

Description

This PR fixes one actual bug with the Viewer2D, and two minor UI issues:

  • After dropping an external image in the 2D viewer, it was impossible to display another image from the Image Gallery, no matter whether it was selected with a click or with the arrow keys;
  • The "Clear node" button was displayed in the 2D viewer, although disabled, even when there was no node to unload, hence creating some confusion;
  • The ComboBox containing the currently loaded node's output attributes could be opened even when no node was loaded (the only default option, "Image Gallery", was dropping down when the user clicked on it).

Features list

  • Correctly display images selected from the Image Gallery in the Viewer2D after an external image has been dropped in it and displayed
  • Hide the "Clear node" button when no node is loaded in the Viewer2D
  • Disable the ComboBox containing the currently loaded node's output attributes when no node is loaded in the Viewer2D

@cbentejac
[ui] Viewer2D: reset the "useExternal" flag after dropping an image i…
feee10e 
…n the Viewer2D
@cbentejac
[ui] Viewer2D: hide the "Clear node" button when no node is displayed
cfa4243 
If only images from the Image Gallery or from external sources are
displayed, no node is currently loaded and a "Clear node" button that
appears, although disabled, is unnecessary and might be confusing.
This commit hides it and only displays it again once it gets enabled.
@cbentejac
[ui] Viewer2D: disable ComboBox to display output attributes if no no…
278538f 
…de is loaded

By default, when no node is selected, only "Image Gallery" is available.
It makes no sense to have the ComboBox dropping down when clicked since
there is nothing to select. If no node is loaded, the ComboBox is disabled.
@fabiencastan fabiencastan added this to the Meshroom 2022.1.0 milestone Nov 30, 2022
@fabiencastan fabiencastan merged commit b3c1196 into develop Nov 30, 2022
@fabiencastan fabiencastan deleted the fix/imgDropViewer2D branch November 30, 2022 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mugulmd mugulmd mugulmd approved these changes

@fabiencastan fabiencastan Awaiting requested review from fabiencastan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Meshroom 2023.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@cbentejac @mugulmd @fabiencastan