Remove support for Python 2 #1837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbentejac
force-pushed
the
dev/stopPython2Support
branch
from
8185426 to
5c3a803
Compare
The compatibility with versions of Python older than 3.5 is not maintained anymore.
- "pyCompatibility.basestring" are replaced by standard Python3 "str" - "Sequence" and "Iterable" from "collections" are now directly imported with "collections.abc"
In particular: - In common/, remove the backport of weakref.WeakMethod - In docs/ and ui/, use the standard FileNotFoundError class - Use built-in open() instead of io.open(), and stop importing io - In core/stats.py, use the standard implementation of xml.etree instead of the C one
Regular expressions in regular strings generate deprecation warnings
with Python 3 ("invalid escape sequence \x"). To fix these warnings,
the regex must be contained within a raw string. For nodes that have
parameters whose description and/or value contain regex, the strings
are transformed into raw strings. In the case of descriptions, which are
generally written across several lines, regular strings are concatenated
with regular strings to preserve line returns (with "\n", which becomes
uneffective in raw strings).
cbentejac
force-pushed
the
dev/stopPython2Support
branch
from
5c3a803 to
2c216b9
Compare
fabiencastan
approved these changes
Dec 6, 2022
fabiencastan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the support of Python 2.7 and early Python 3 (< 3.5) versions from Meshroom.
The continuous integration action rules are updated to only lint and test with Python 3.8. The requirements and installation documentation are updated accordingly.
All the workarounds used to support both Python 2.7 and Python 3 are removed. In particular, the "pyCompatibility" module and all references to it are deleted. Deprecation warnings highlighted by the unit tests are fixed.
Finally, Dockerfiles that are specific to Python 2 are removed, and build scripts that contain exclusive bits of code to handle Python 2 are updated to only refer to Python 3.
Features list