[ui] Use the location of the most recently imported images as the base folder for the "Import Images" dialog #1864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbrood
approved these changes
Jan 10, 2023
mugulmd
reviewed
Jan 10, 2023
mugulmd
reviewed
Jan 10, 2023
|
Could also be interesting to make this feature work in-between sessions |
This commit changes the folder in which the "Import Images" dialog opens: it used to be opened in the folder in which the last .mg file had been opened, and it now opens in the folder from which the last images were imported. The location of the last imported images is saved, and used specifically when opening the "Import Images" dialog, as opposed to all the other dialogs which open in the folder of the last opened .mg file.
cbentejac
force-pushed
the
dev/saveImportImagesFolder
branch
3 times, most recently
from
6f8812a to
125a391
Compare
Done, the folders are now saved across sessions!
Also done. If no folder has been saved yet (or if the settings have all been reset), and the user opens a .mg file that contains images before trying to import images, the base folder for the "Import Images" dialog will be the location of the project's images. |
…e base folder If a project has already been opened before the "Import Images" dialog is opened for the first time, and if the opened project has imported images, use the location of these images' folder as the base folder for the "Import Images" dialog. If the opened project has no imported images, the base folder will remain identical to the other dialogs' until images are imported.
Save up to 3 folder locations from which images have been imported. These folder locations will be saved across Meshroom sessions, in a similar fashion as the "Recent Files" entries. If no folder location has been saved (or if all saved folder locations are invalid), we fall back to the default behaviour: if a project with images has been opened before the "Import Images" action is called, then the base folder will be the folder containing the opened project's images.
cbentejac
force-pushed
the
dev/saveImportImagesFolder
branch
from
125a391 to
1b5e33c
Compare
…aved Prior to saving the images' locations across sessions, if no image had been yet imported but a project file with images had been opened, the default base folder for the session became the project images' location. The location of dropped images back then was never saved. Now that the locations from the "Import Images" are saved across session, the possibilities of having no location saved have drastically decreased. The three cases where it can happen are the following: - the user has never opened Meshroom before (or the user has been using Meshroom without ever using "Import Images") - the user has cleared their Meshroom settings - the 3 saved locations have become invalid For these three cases, the default base folder is either set to the location of the first dropped image or to the opened project's images. That location is NOT saved for later sessions. Using the "Import Images" action is necessary for the location to be saved.
fabiencastan
approved these changes
Jan 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since #1778, all the actions from the "File" menu that open dialogs use the folder of the .mg file that was opened last as the base folder.
This is also the case for the "Import Images" dialog, which means that at each import, the dialog opens in the folder containing the most recently opened .mg file rather than the most recently imported images.
This PR changes that behaviour by saving the location of the last imported images, and using it as the base folder specifically for the "Import Images" dialog. The new behaviour can be summed up as follows:
The base folder for all the other file dialogs ("Open", "Save As", "Import Project", "Save As Template") remains unchanged.
Features list