[nodes] KeyframeSelection: Rework the node and add parameters for new selection methods #1880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
cbentejac
force-pushed
the
dev/cleanKeyframeSelection
branch
2 times, most recently
from
b1ec6fb to
4ab9ace
Compare
This commit removes most of the existing parameters for the keyframe selection and adds new ones to enable the regular keyframe selection. Since the regular method is the only one available for now, the parameter that allows the user to enable it or not is disabled.
Group the keyframe selection parameters together depending on the method (regular or smart) they belong to. Parameters for a method are only shown if that method is the currently selected one.
…ction If enabled, the scores are computed and, if requested, exported to a CSV file, but the keyframe selection itself is not performed.
…ectors Add two debug options to export the computed motion vectors in HSV as PNG images.
Keyframes will be written as JPG, PNG or EXR files (by default, JPG). If EXR is the selected output extension, the storage data type can also be chosen.
Split the existing "rescaledWidth" parameter into "rescaledWidthSharpness" and "rescaledWidthFlow" to allow independent rescaling of the frames used to compute the sharpness and motion scores.
cbentejac
force-pushed
the
dev/cleanKeyframeSelection
branch
from
b62e75d to
bdf1325
Compare
…vely By default, the keyframes' name is their index within the input sequence / video. A new option is added to name them as consecutive frames, starting from 0, instead.
…tions Add a debug option that will, during the scores' computation, skip all the calculations regarding sharpness. A fixed sharpness score of 1.0 will be applied to all the frames.
mugulmd
approved these changes
Mar 9, 2023
fabiencastan
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is related to alicevision/AliceVision#1343 and replaces #1765.
It removes the parameters that were previously used for the Keyframe Selection and replaces them with new ones, corresponding to the two newly added selection methods:
Features list