[ImageGallery] Match the filter selection with the gallery's display #1899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Selecting any filter in the Image Gallery changes the displayed content of the gallery according to the filter. Unselecting any filter automatically switches the displayed content back to the "input images" filter (which simply displays all the input images), but the "input images" button is never reselected, meaning that there can be a display corresponding to a filter without any filter being selected. This commit prevents unselecting a filter without reselecting the one corresponding to the display. Since the "input images" is always the display that is reverted to, unselecting any filter automatically selects its button.
fabiencastan
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Selecting any filter in the Image Gallery changes the displayed content of the gallery according to the filter. Unselecting any filter automatically switches the displayed content back to the "input images" filter (which simply displays all the input images), but the "input images" button is never reselected, meaning that there can be a display corresponding to a filter without any filter being selected, as shown in the image below.
This PR prevents unselecting a filter without reselecting the one corresponding to the display. Since the "input images" is always the display that is reverted back to, unselecting any filter automatically selects its button: