[pipelines] Panorama: Fix inputs of the "Publish" nodes #1922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbentejac
force-pushed
the
fix/panoramaTemplates
branch
from
ff1e159 to
f6609ea
Compare
The "Publish" nodes were connected to "ImageProcessing" nodes, which used to be part of the panorama pipelines, but are not anymore.
cbentejac
force-pushed
the
fix/panoramaTemplates
branch
from
f6609ea to
1c5efc2
Compare
fabiencastan
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#1819 introduced a new node,
PanoramaPostProcessing, that was added at the end of the Panorama templates to replace theImageProcessingnode.#1903 however added
Publishnodes at the end of the Panorama templates with the pipelines using theImageProcessingas a reference, which left us with templates that correctly usedPanoramaPostProcessinginstead ofImageProcessing, but expected thePublishnode to be connected to theImageProcessing's output.This PR correctly connects the
Publishnodes to thePanoramaPostProcessingoutputs.