Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ui] add new patterns to load images in viewer2D #1975

Merged
merged 1 commit into from
Apr 18, 2023
Merged

[ui] add new patterns to load images in viewer2D #1975

merged 1 commit into from
Apr 18, 2023

Conversation

sbrood
Copy link
Contributor

@sbrood sbrood commented Apr 12, 2023

Description

This PR adds the support of new patterns to load images in the 2D image viewer. It will also be easier to add ones.

Features list

  • Add < FILENAME > and < INSTRINSIC_ID > pattern
  • patterns are given through a dictionary

@sbrood sbrood requested review from cbentejac and mugulmd April 12, 2023 16:21
@fabiencastan fabiencastan added this to the Meshroom 2023.2.0 milestone Apr 12, 2023
@sbrood sbrood requested review from mugulmd and fabiencastan April 18, 2023 07:36
@mugulmd
Copy link
Contributor

mugulmd commented Apr 18, 2023

Your 2nd commit is labeled TO SQUASH, can you squash it so the git history is clean ? Thanks 😄

@sbrood sbrood force-pushed the dev/viewer2DFilePathPatterns branch from 6072542 to 731440e Compare April 18, 2023 12:46
@fabiencastan fabiencastan merged commit b3d73e6 into develop Apr 18, 2023
@fabiencastan fabiencastan deleted the dev/viewer2DFilePathPatterns branch April 18, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mugulmd mugulmd mugulmd approved these changes

@cbentejac cbentejac Awaiting requested review from cbentejac

@fabiencastan fabiencastan Awaiting requested review from fabiencastan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Meshroom 2023.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@sbrood @mugulmd @fabiencastan