[nodes] KeyframeSelection: Set a dynamic size for the node #2039
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related AliceVision pull request: alicevision/AliceVision#1457
This PR sets a dynamic size for the
KeyframeSelection
node, thus allowing the nodes that follow to be chunked if applicable.As its number of outputs can rarely be precisely known before it is actually computed, we set the size with what we know to be the maximum number of keyframes.
There are 3 cases to determine what the maximum number of keyframes will be:
a. If the maximum number of output frames for the regular selection is set, then the size is the minimum between the number of input frames and the maximum number of output frames for the regular selection;
b. If the maximum number of output frames for the regular selection is not set, we fall back to 1).