Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support display and connection of attributes that are part of GroupAttributes #2544

Open
wants to merge 7 commits into
base: fix/minorUiFixes
Choose a base branch
from
Open

Support display and connection of attributes that are part of GroupAttributes #2544

wants to merge 7 commits into from

Commits on Oct 4, 2024

  1. [core] Attribute: Add notion of depth for attributes with parents 

    For attributes in `GroupAttribute` and `ListAttribute`, the notion of
parent attribute exists through the `root` property. As a parent can
itself have a parent, the `depth` property describes how many levels
there are between the attribute and the root level.

A value of 0 means that the attribute is at the root level, and it
increases as it gets deeper.
    @cbentejac
    cbentejac committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    a499f47 View commit details
    Browse the repository at this point in the history

  2. [core] Attribute: Add a flattenedChildren property 

    `flattenedChildren` returns the list of all the attributes that refer
to this attribute as their parent (either direct or indirect) through
the `root` property. The search for the children attributes is recursive
and alllows to retrieve at once all the nested attributes, independently
from their level.

At the moment, only `ListAttribute` and `GroupAttribute` will return a
non-empty list of flattened children attributes.
    @cbentejac
    cbentejac committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    e67e789 View commit details
    Browse the repository at this point in the history

  3. [core] Correctly match descriptions for connected attributes within g… 

    …roups
    @cbentejac
    cbentejac committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    a5958a6 View commit details
    Browse the repository at this point in the history

  4. [core] Attribute: Parent's exposed property takes precedence over d… 

    …escription's

The `exposed` property, which determines whether the attribute is
displayed on the upper part of the node in the Graph Editor, is set
for each attribute individually in their node's description.

If an attribute has a parent (meaning it depends on a `GroupAttribute` or
a `ListAttribute`) whose `exposed` property value differs, it does not
make sense to display it separately from it. The attribute's `exposed`
should align with its parent's.
    @cbentejac
    cbentejac committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    257e91e View commit details
    Browse the repository at this point in the history

  5. [GraphEditor] Allow to display and connect attributes within `GroupAt… 

    …tribute`
    @cbentejac
    cbentejac committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    1c7482a View commit details
    Browse the repository at this point in the history

  6. [ui] Graph: canExpandForLoop: Ensure all checks are performed on a … 

    …`ListAttribute`
    @cbentejac
    cbentejac committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    ed4dc3f View commit details
    Browse the repository at this point in the history

  7. [GraphEditor] Refer to an attribute's parent in its tooltip 

    If an attribute belongs to a `GroupAttribute` or a `ListAttribute`,
it has a parent, and its full name is "parentName.attributeName".
Instead of displaying only "attributeName" in the tooltip, this commit
now displays "parentName.attributeName" to ensure that the link is obvious.
    @cbentejac
    cbentejac committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    0cdfd8b View commit details
    Browse the repository at this point in the history