Add support for QML debugging/profiling #2623
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yann-lty
force-pushed
the
dev/qmlDebuggerSetup
branch
from
9ef0003 to
58e41e1
Compare
Instead of passing the style via QApplication arguments, use the QQuickStyle API.
Introduce new environment variable to enable and configure QML debugging when starting Meshroom GUI app. Introduce a new EnvVar class to centralize the management of environment variables across Meshroom.
Add a new CLI option to print the available Meshroom environment variables and their descriptions.
yann-lty
force-pushed
the
dev/qmlDebuggerSetup
branch
from
58e41e1 to
c20ecaa
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2623 +/- ##
========================================
Coverage 69.90% 69.90%
========================================
Files 121 121
Lines 7078 7078
========================================
Hits 4948 4948
Misses 2130 2130 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the required setup to be able to attach the QML debugger/profiler to Meshroom.
QML debugging can be activated using the environment variable
And optionally configured using (with params as expected by -qmljsdebugger):
The help of those environment variables can be accessed via CLI using:
Usage
Debugger
This can be used to attach the QML debugger from Qt Creator, using:
Profiler
This setup can also be used to attach the QML profiler, either interactively from Qt Creator
or from command line:
Features list
--env-helpCLI option to Meshroom app to display env var help/documentationImplementation remarks
This PR also introduces an new class
EnvVar(meshroom.env.EnvVar) that is designed to centralize the management of environment variables in Meshroom.