New panorama pipeline for fisheye images #808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiencastan
force-pushed
the
dev/panoramaFisheye
branch
2 times, most recently
from
f72a710 to
a7b88a0
Compare
* update HDRI pipeline * rename the fake tractor dependency param to make it more explicit that it is only used for dependency (and not as a real input)
…ctly on command line
… command line Avoid error with negative values on "y" interpreted as a new argument
fabiencastan
force-pushed
the
dev/panoramaFisheye
branch
from
7557333 to
dcf91c2
Compare
* fix path conversion on windows * remove invalid paths from the list on error * explicit error message for "No Such File"
Watching the subprocess for statistics may create errors on windows on specific cases, it should not break the UI.
This is necessary since version 5.14 of Qt, otherwise the model is not updated and remains empty.
FeaturesInfoOverlay relies on the FeatureViewer, so we ensure that it is loaded first.
The internal MouseArea in the FloatImage is used to retrieve the mouse over events but should not catch the other mouse events.
Ensure that the important part of the number is displayed.
…rl+Wheel * also add forceActiveFocus() to release other focus areas
Setup the 2 fisheye options on LDRToHDR and PanoramaInit nodes.
- update access to CameraInit from LdrToHdr nodes - update PanoramaPrepareImages param names
Avoid to cut too much connections.
julien-hdev
approved these changes
Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for HDRI creation from fisheye images.
Features list
See alicevision/AliceVision#749