Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Augmenting instructions re setting up qml extensions #909

Closed
wants to merge 5 commits into from

Conversation

julianrendell
Copy link

I tried both ; and : as path separators for QML2_IMPORT_PATH and had no luck. Change above was the first method that got everything enabled.

I tried both `;` and `:` as path separators for `QML2_IMPORT_PATH` and had no luck. Change above was the first method that got everything enabled.
INSTALL.md Outdated
@@ -46,6 +46,24 @@ Additional Qt plugins can be built to extend Meshroom UI features. They can be f
though they might get better integration in the future.
Note that they are optional but highly recommended.

For Windows, there may be problems setting `QML2_IMPORT_PATH` to contain multiple paths. The easiest approach may be to duplicate what is done for the binary release. This has a directory structure like this:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to avoid "may be" in the wording of the documentation. Documentation is there to provide information that people can trust.

From Qt documentation QML2_IMPORT_PATH is supposed to accept multiple paths.
https://doc.qt.io/qt-5/qtqml-syntax-imports.html
Multiple path entries must be separated by ':' under Unix and ';' under Windows.

Could you double check? If it doesn't work, it would be good to report an issue on the Qt project.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tried:

set QML2_IMPORT_PATH="D:\Meshroom_Dev\qmlAlembic\qml;D:\Meshroom_Dev\QtOIIO\qml;D:\Meshroom_Dev\QtAliceVision\qml"

python meshroom/ui 

and none of the plugins are available.

I've created https://bugreports.qt.io/browse/QTBUG-84390

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reworded the pull request. It's purposely worded more passively as I'm don't regularly build large projects any more, and even less so on Windows. There's a very large chance I've broken something when I used vcpkg built qt :-)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And added a link to the QT bug.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After follow up on https://bugreports.qt.io/browse/QTBUG-84390, turns out quotes don't work in path specifications.

The things you learn.

Update to remove most of the changes, add a comment re quotes, and tweak the example path specs to add to, rather than replace.

@stale stale bot added the stale for issues that becomes stale (no solution) label Sep 25, 2020
@stale stale bot closed this Oct 2, 2020
@natowi natowi reopened this Oct 2, 2020
@stale stale bot removed the stale for issues that becomes stale (no solution) label Oct 2, 2020
@stale stale bot added the stale for issues that becomes stale (no solution) label Jan 30, 2021
@natowi natowi removed the stale for issues that becomes stale (no solution) label Jan 30, 2021
@alicevision alicevision deleted a comment from stale bot Feb 12, 2021
@alicevision alicevision deleted a comment from stale bot Feb 12, 2021
@alicevision alicevision deleted a comment from stale bot Feb 12, 2021
@natowi
Copy link
Member

natowi commented Feb 16, 2021

An alternative would be #1169 (placing alicevision and qtplugins in same meshroom root folder instead of setting the path(s))

@stale
Copy link

stale bot commented Jun 16, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale for issues that becomes stale (no solution) label Jun 16, 2021
@natowi natowi removed the stale for issues that becomes stale (no solution) label Jun 20, 2021
@stale
Copy link

stale bot commented Oct 22, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale for issues that becomes stale (no solution) label Oct 22, 2021
@stale
Copy link

stale bot commented Dec 9, 2021

This issue is closed due to inactivity. Feel free to re-open if new information is available.

@stale stale bot closed this Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale for issues that becomes stale (no solution)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants