Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --add & --rm commands to actions menu #129

Closed
alichtman opened this issue Oct 23, 2018 · 4 comments
Closed

Add --add & --rm commands to actions menu #129

alichtman opened this issue Oct 23, 2018 · 4 comments
Assignees
Labels
feature New feature or request UI/UX
Milestone

Comments

@alichtman
Copy link
Owner

When a user is shown a menu, the options to add and rm a path from the config should be shown.

The user should be prompted for a folder and then prompted for a path, and then the correct action should be performed.

The program should exit afterwards.

@alichtman alichtman added feature New feature or request help wanted Extra attention is needed good first issue Good for newcomers Hacktoberfest UI/UX labels Oct 23, 2018
@ghost
Copy link

ghost commented Oct 26, 2018

Hey, I'd like to take a swing at this, but I would like to clarify: do you mean "adding" and "removing" a path as in editing the config file, separate from another action? Or "adding" and "removing" as in "complete this action, but with this path added and with this path removed"

@alichtman
Copy link
Owner Author

alichtman commented Oct 27, 2018

as in editing the config file

Yep, so I've already written the implementation for --add and --rm as CLI args. All that's needed is access to them in the CLI. Also, take a look at #140 to see if you have any thoughts about improving the usage/want to take on any of those.

It should work like this:

  1. Add an option to the actions menu to edit the config fie.
  2. Display the config
  3. Ask whether they'd like to add or remove a path.
    • If they're adding a path, prompt them for a subfolder and then the path.
    • If they're removing a path, they should have a selection of paths they can remove.
  4. Bring them back to the action menu. (This may require a little refactoring.)

@alichtman
Copy link
Owner Author

NOTE: Wait for #157 to be merged in before working on this.

@alichtman
Copy link
Owner Author

alichtman commented Oct 28, 2018

It would be cool if we printed example formatting to clearly show the user how to enter the path. No longer necessary because of #161

alichtman added a commit that referenced this issue Oct 30, 2018
@alichtman alichtman self-assigned this Oct 30, 2018
@alichtman alichtman removed good first issue Good for newcomers help wanted Extra attention is needed labels Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request UI/UX
Projects
None yet
Development

No branches or pull requests

1 participant