-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Refactor and support encoding to timestamp and decoding to date #58
base: master
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Thanks a lot for working on this! TBH, this Pull request is massive, it is really hard to review it. Could you please split it to smaller pull requests with more concrete goals? And about cleaning up, the way the code is organized now is intentional, to reflect the structure of the JSONEncoder and JSONDecoder in apple/swift, so I would prefer to keep it as close to that as possible
It'd be great to see this merged so we could map Date to Timestamp |
CAN WE GET THIS INTO MASTER? |
This looks awesome. Any chance we could get this merged? For now I think I'll make a fork, because this is such a big quality of life improvement for me |
Bump |
I'd like to keep the model clean, without any dependency from firestore, which limits us to use Date, and not Timestamp. This PR adds an ability of it.
I also refactor and clean the code a bit.
I haven't use and test other types. gonna work on them later...