Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OpenAPI] Add endpoint for list event details #217

Closed
justinyoo opened this issue Aug 17, 2024 · 2 comments · Fixed by #265
Closed

[OpenAPI] Add endpoint for list event details #217

justinyoo opened this issue Aug 17, 2024 · 2 comments · Fixed by #265
Assignees
@tae0y
Labels
admin openapi ossca task team-kim

Comments

@justinyoo
Copy link
Contributor

  • OpenAPI doc only - no implementation
  • GET
  • /admin/events
This was referenced Aug 17, 2024
Open
Open
Open
Open
@tae0y
Copy link
Contributor

tae0y commented Aug 24, 2024

진행해보겠습니다 !

@tae0y
Copy link
Contributor

tae0y commented Aug 24, 2024 •
edited
Loading

이런 것을 고민해보고 있어욥

  • 엔드포인트 이름 : /admin/events
  • Request 파라미터는
    • 별도 지정없이 해당되는 모든 이벤트 목록을 조회
  • Response 반환타입은
    • AdminEventDetails 모델을 List<>로 감싸 재사용
    • 불필요한 파라미터는 차후에 lazy loading? 혹은 null로? AdminEventSummary와 같은 별도 모델로 분리?

@tae0y tae0y mentioned this issue Aug 24, 2024
Merged
@justinyoo justinyoo linked a pull request Aug 24, 2024 that will close this issue
[OpenAPI] Add endpoint for list event details #217 #265
Merged
justinyoo pushed a commit that referenced this issue Aug 24, 2024
@tae0y
[OpenAPI] Add endpoint for list event details #217 (#265)
bdbd200
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tae0y tae0y

Labels
admin openapi ossca task team-kim
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[OpenAPI] Add endpoint for list event details #217 tae0y/azure-openai-sdk-proxy
2 participants
@justinyoo @tae0y