Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Admin] 스토리지 커넥션 개체 생성 #300

Closed
justinyoo opened this issue Sep 5, 2024 · 1 comment · Fixed by #299 or #317
Closed

[Admin] 스토리지 커넥션 개체 생성 #300

justinyoo opened this issue Sep 5, 2024 · 1 comment · Fixed by #299 or #317
Assignees
@sikutisa
Labels
backend ossca task team-park

Comments

@justinyoo
Copy link
Contributor

@justinyoo justinyoo linked a pull request Sep 5, 2024 that will close this issue
[Admin] Table Storage Connection Setting #299
Merged
@justinyoo justinyoo mentioned this issue Sep 5, 2024
Merged
@sikutisa
Copy link
Contributor

sikutisa commented Sep 6, 2024

현재 제가 #299 PR에서 작업하고 있습니다.

sikutisa added a commit to sikutisa/azure-openai-sdk-proxy that referenced this issue Sep 7, 2024
@sikutisa
fix StorageAccountSettings
4db5c7c 
get azure storage connection string from key vault

Related to: aliencube#300
sikutisa added a commit to sikutisa/azure-openai-sdk-proxy that referenced this issue Sep 7, 2024
@sikutisa
fix AddTableStorageService
8f33257 
refactor to use KeyVault

Related to: aliencube#300
sikutisa added a commit to sikutisa/azure-openai-sdk-proxy that referenced this issue Sep 7, 2024
@sikutisa
fix AddTableStorageService
dd11045 
Related to: aliencube#300
sikutisa added a commit to sikutisa/azure-openai-sdk-proxy that referenced this issue Sep 7, 2024
@sikutisa
refactor appsettings.json
40ade5e 
Related to: aliencube#300
sikutisa added a commit to sikutisa/azure-openai-sdk-proxy that referenced this issue Sep 7, 2024
@sikutisa
refactor Configurations
3e416a1 
Related to: aliencube#300
sikutisa added a commit to sikutisa/azure-openai-sdk-proxy that referenced this issue Sep 7, 2024
@sikutisa
refactor WithKeyVault
1418525 
Related to: aliencube#300
sikutisa added a commit to sikutisa/azure-openai-sdk-proxy that referenced this issue Sep 7, 2024
@sikutisa
refactor AddTableStorageService
cdf174c 
Related to: aliencube#300
sikutisa added a commit to sikutisa/azure-openai-sdk-proxy that referenced this issue Sep 7, 2024
@sikutisa
update KeyvaultSettings and tests
f57decc 
Related to: aliencube#300
sikutisa added a commit to sikutisa/azure-openai-sdk-proxy that referenced this issue Sep 7, 2024
@sikutisa
fix test
ceaa16b 
Related to: aliencube#300
sikutisa added a commit to sikutisa/azure-openai-sdk-proxy that referenced this issue Sep 7, 2024
@sikutisa
refactor KeyVaultSettings
b84d2f1 
Related to: aliencube#300
sikutisa added a commit to sikutisa/azure-openai-sdk-proxy that referenced this issue Sep 7, 2024
@sikutisa
refactor KeyVaultSettings
c7f34e6 
Related to: aliencube#300
sikutisa added a commit to sikutisa/azure-openai-sdk-proxy that referenced this issue Sep 11, 2024
@sikutisa
fix tests
4ba8666 
If a null secretName is given, a KeyNotFoundException is thrown instead of an InvalidOperationException.

Related to: aliencube#300
sikutisa added a commit to sikutisa/azure-openai-sdk-proxy that referenced this issue Sep 11, 2024
@sikutisa
add KeyVaultSecretNames.cs
02946bc 
Related to: aliencube#300
sikutisa added a commit to sikutisa/azure-openai-sdk-proxy that referenced this issue Sep 12, 2024
@sikutisa
add validation for null or empty table storage secret name
6628d53 
Related to: aliencube#300
sikutisa added a commit to sikutisa/azure-openai-sdk-proxy that referenced this issue Sep 12, 2024
@sikutisa
add tests
3f4c253 
Related to: aliencube#300
sikutisa added a commit to sikutisa/azure-openai-sdk-proxy that referenced this issue Sep 12, 2024
@sikutisa
add tests
33a55d0 
Related to: aliencube#300
@sikutisa sikutisa mentioned this issue Sep 12, 2024
Merged
justinyoo pushed a commit that referenced this issue Sep 13, 2024
@sikutisa
add tests (#317)
4edf7a8 
Related to: #300
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sikutisa sikutisa

Labels
backend ossca task team-park
Projects
None yet
Milestone
No milestone
2 participants
@justinyoo @sikutisa