-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OpenAPI] Add endpoint for update event details #241
[OpenAPI] Add endpoint for update event details #241
Conversation
babc355
to
9ffee77
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
몇가지 수정사항 코멘트 남겨뒀습니다.
test/AzureOpenAIProxy.AppHost.Tests/ApiApp/Endpoints/AdminUpdateEventDetailsOpenApiTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
거의 다 온 것 같네요. 코멘트 추가했습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
하나 더!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OpenAPI 문서 린팅 규칙도 추가해야겠네요.
azure-openai-sdk-proxy/.spectral.yaml
Lines 75 to 83 in 485cbe9
# 401을 제외한 모든 응답 코드는 content를 포함해야함 | |
operation-responsedetail-content-convention: | |
description: All Operation response might include content, except 401 | |
given: $.paths[*][*].responses[?(@property != '401')] | |
severity: error | |
then: | |
- field: 'content' | |
function: truthy | |
message: Content is required |
여기 참고해서 현재 401만 예외처리되어 있는데, 400과 404도 예외규칙에 추가해 주세요.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다! LGTM
#202
AddAdminEvents 함수 변경점
Add -> Map으로 이름 변경
Add
, 미들웨어 추가 시Use
, 엔드포인트 추가 시Map
으로 지정하였습니다.리턴 타입과 인수를
IEndpointRouteBuilder
로 변경신규 엔드포인트
UpdateAdminEventDetails
추가테스트 코드 추가: 신규 엔드포인트
UpdateAdminEventDetails
확인 부탁드립니다. 감사합니다.