Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Admin/Playground] Update main layout to show/hide the sidebar #254

Merged
merged 7 commits into from
Aug 22, 2024
Merged

[Admin/Playground] Update main layout to show/hide the sidebar #254

merged 7 commits into from
Aug 22, 2024

Conversation

justinyoo
Copy link
Contributor

Related to #252

This PR is:

  • To add UI logic to show the sidebar only if they're admin pages
  • To add UI test logic
  • To refactor the code part from the UI logic part (.razor file) to partial class (.cs file)

@justinyoo justinyoo self-assigned this Aug 22, 2024
@justinyoo justinyoo linked an issue Aug 22, 2024 that may be closed by this pull request
[Playground/Admin] Display sidebar only at the admin page #252
Closed
@justinyoo
Copy link
Contributor Author

Test Results

✔️ Tests 95 / 95 - passed in 17.1s
🔍 click here for more details

@justinyoo
Copy link
Contributor Author

Test Results

✔️ Tests 95 / 95 - passed in 15.6s
🔍 click here for more details

✏️ updated for commit 2e545bc

@justinyoo
Copy link
Contributor Author

Test Results

❌ Tests 93 / 94 (1 failed, 0 skipped) - failed in 15.5s
🔍 click here for more details

✏️ updated for commit f1bb081

@justinyoo
Copy link
Contributor Author

Test Results

❌ Tests 93 / 94 (1 failed, 0 skipped) - failed in 16.9s
🔍 click here for more details

✏️ updated for commit 4579103

@justinyoo
Copy link
Contributor Author

Test Results

❌ Tests 93 / 94 (1 failed, 0 skipped) - failed in 16.9s
🔍 click here for more details

✏️ updated for commit cdc913d

@justinyoo
Copy link
Contributor Author

Test Results

✔️ Tests 94 / 94 - passed in 15.6s
🔍 click here for more details

✏️ updated for commit a40c787

@justinyoo
Copy link
Contributor Author

Test Results

✔️ Tests 94 / 94 - passed in 14.7s
🔍 click here for more details

✏️ updated for commit 0627f77

@justinyoo justinyoo merged commit ed1e262 into main Aug 22, 2024
1 check passed
@justinyoo justinyoo linked an issue Aug 22, 2024 that may be closed by this pull request
[Playground/Admin] Add Fluent UI library #250
Closed
@justinyoo justinyoo changed the title Update main layout to show/hide the sidebar [Admin/Playground] Update main layout to show/hide the sidebar Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@justinyoo justinyoo

Labels
admin ossca playground task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Playground/Admin] Display sidebar only at the admin page [Playground/Admin] Add Fluent UI library
1 participant
@justinyoo