Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Admin] Component: List event details - UI component #219 #266

Merged
merged 12 commits into from
Sep 6, 2024
Merged

[Admin] Component: List event details - UI component #219 #266

merged 12 commits into from
Sep 6, 2024

Conversation

praivesi
Copy link
Contributor

@praivesi praivesi commented Aug 24, 2024 •
edited
Loading

개요

#219

목표: Admin 사용자가 브라우저를 통해 '/admin/events' 로 접속 시 Admin Events 화면이 표출

구현 화면

스크린샷 2024-08-27 오전 2 15 50

구현 내용

1. Admin Events Page 구현

  1. 페이지 기본 정보를 출력
  2. AdminEventsComponent 컴포넌트를 이용해 이벤트 목록 표시

2. AdminEventsComponent구현

  1. eventDetails 객체를 생성하여 AdminEventDetails 목록 관리
  2. eventDetails 객체에 있는 정보를 FluentDataGrid로 표시
  3. AdminEventIsActiveComponent 컴포넌트를 이용해 AdminEventDetails 객체의 IsActive 필드값을 테이블에 표시

3. AdminEventIsActiveComponent 구현

  1. AdminEventDetails 객체의 IsActive 값이 true 이면 초록, false이면 빨강으로 표시

4. 테스트 추가

  1. AdminEventsPageTests를 추가하여 웹 페이지의 /events 경로로 접속 시 반드시 있어야 하는 요소가 있는지 확인
  • 이벤트 목록 컴포넌트 ("#admin-events-component")
  • 이벤트 테이블 ("#admin-events-table")

@justinyoo justinyoo linked an issue Aug 24, 2024 that may be closed by this pull request
[Admin] Component: List event details - UI component #219
Closed
@praivesi praivesi force-pushed the task/219-list-ui-component branch 3 times, most recently from 96f49f6 to 763000f Compare August 26, 2024 17:14
justinyoo
justinyoo requested changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@justinyoo justinyoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코멘트 확인해 주세요!

src/AzureOpenAIProxy.PlaygroundApp/AzureOpenAIProxy.PlaygroundApp.csproj Outdated Show resolved Hide resolved
src/AzureOpenAIProxy.PlaygroundApp/AzureOpenAIProxy.PlaygroundApp.csproj Outdated Show resolved Hide resolved
...AzureOpenAIProxy.PlaygroundApp/Components/UI/Admin/AdminEventDetailElemActiveComponent.razor Outdated Show resolved Hide resolved
...AzureOpenAIProxy.PlaygroundApp/Components/UI/Admin/AdminEventDetailElemActiveComponent.razor Outdated Show resolved Hide resolved
src/AzureOpenAIProxy.PlaygroundApp/Components/UI/Admin/AdminListEventDetailsComponent.razor Outdated Show resolved Hide resolved
test/AzureOpenAIProxy.PlaygroundApp.Tests/Pages/AdminEventsPageTests.cs Outdated Show resolved Hide resolved
src/AzureOpenAIProxy.PlaygroundApp/Components/Pages/AdminEvents.razor Outdated Show resolved Hide resolved
@justinyoo
Copy link
Contributor

@praivesi 빌드 깨졌습니다~

@praivesi praivesi force-pushed the task/219-list-ui-component branch 5 times, most recently from 429c525 to a87044d Compare August 28, 2024 11:15
@praivesi
Copy link
Contributor Author

@praivesi 빌드 깨졌습니다~

24.08.28 기준으로 rebase 하여 다시 PUSH 했습니다!

justinyoo
justinyoo requested changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@justinyoo justinyoo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

몇가지 네이밍 컨벤션이랑 scoped CSS 쓰는 쪽으로 바꿔보시지요.

test/AzureOpenAIProxy.PlaygroundApp.Tests/Pages/AdminEventsPageTests.cs Outdated Show resolved Hide resolved
test/AzureOpenAIProxy.PlaygroundApp.Tests/Pages/AdminEventsPageTests.cs Outdated Show resolved Hide resolved
test/AzureOpenAIProxy.PlaygroundApp.Tests/Pages/AdminEventsPageTests.cs Outdated Show resolved Hide resolved
src/AzureOpenAIProxy.PlaygroundApp/Components/UI/Admin/AdminEventsComponent.razor Outdated Show resolved Hide resolved
src/AzureOpenAIProxy.PlaygroundApp/Components/UI/Admin/AdminEventIsActiveComponent.razor Outdated Show resolved Hide resolved
src/AzureOpenAIProxy.PlaygroundApp/Components/UI/Admin/AdminEventIsActiveComponent.razor Outdated Show resolved Hide resolved
src/AzureOpenAIProxy.PlaygroundApp/Components/UI/Admin/AdminEventsComponent.razor Outdated Show resolved Hide resolved
justinyoo
justinyoo requested changes Aug 31, 2024
View reviewed changes
Copy link
Contributor

@justinyoo justinyoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

몇가지 간단한 하우스키핑 정도만 해 보시지요.

src/AzureOpenAIProxy.PlaygroundApp/Components/Pages/AdminEvents.razor Outdated Show resolved Hide resolved
src/AzureOpenAIProxy.PlaygroundApp/Components/UI/Admin/AdminEventsComponent.razor Outdated Show resolved Hide resolved
src/AzureOpenAIProxy.PlaygroundApp/Components/UI/Admin/AdminEventsComponent.razor Outdated Show resolved Hide resolved
@praivesi praivesi force-pushed the task/219-list-ui-component branch 2 times, most recently from 1d33397 to 86beb22 Compare September 1, 2024 10:04
@praivesi
Copy link
Contributor Author

praivesi commented Sep 1, 2024

몇가지 간단한 하우스키핑 정도만 해 보시지요.

@using 과 private scope 정리하였습니다!

@justinyoo
Copy link
Contributor

빌드 깨집니다! 리포지토리 최신화 해 보신 후에 다시 해 보세요.

@praivesi
test: add Playground UI tests when navigated to /events
c81d308
@praivesi
refac: apply PR review 1
65ae19e 
- src/AzureOpenAIProxy.PlaygroundApp/Components/Layout/NavMenu.razor 변경 내역 제거
- 불필요한 attribute 제거
- PlaygroundApp 프로젝트에 ApiApp 프로젝트를 참조 추가하여 ApiApp.Models.AdminEventDetails 사용
- 테스트 파일 이름 변경 (EventPageTests -> AdminEventPageTests)
- AdminEventPageTests 테스트에서 테이블 로드 waiting 시간 변경 (0.2 sec => 2 sec)
- EventDetailElemComponent 에서 SubText property의 타입을 nullable로 변경
@praivesi
refac: apply PR review 2 - DataGrid
2ec5d9b 
- ListEventDetailsComponent 에서 <table> 대신 DataGrid를 사용하는 방식으로 변경
@praivesi
refac: apply PR review 3
a7c363a
@praivesi
refac: PR review 반영 4
b1cfea0
@praivesi
refac: PR 리뷰 반영 5
6c899bf
@praivesi
Copy link
Contributor Author

praivesi commented Sep 2, 2024

빌드 깨집니다! 리포지토리 최신화 해 보신 후에 다시 해 보세요.

24.09.02 기준으로 최신화 하였습니다!

justinyoo
justinyoo requested changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@justinyoo justinyoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

딱 두 가지만 더 수정하면 될 듯 합니다!

src/AzureOpenAIProxy.PlaygroundApp/Models/AdminEventDetails.cs Outdated Show resolved Hide resolved
test/AzureOpenAIProxy.PlaygroundApp.Tests/Pages/AdminEventsPageTests.cs Outdated Show resolved Hide resolved
@praivesi
Copy link
Contributor Author

praivesi commented Sep 4, 2024

딱 두 가지만 더 수정하면 될 듯 합니다!

두 가지 모두 수정 완료하였습니다.
더 필요한 부분 있으시면 말씀해주세요 !

justinyoo
justinyoo approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@justinyoo justinyoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다! LGTM!

@justinyoo justinyoo merged commit 7a2c3b8 into aliencube:main Sep 6, 2024
1 check passed
@justinyoo justinyoo mentioned this pull request Sep 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinyoo justinyoo justinyoo approved these changes

Assignees

@praivesi praivesi

Labels
admin ossca task team-oh
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Admin] Component: List event details - UI component
2 participants
@praivesi @justinyoo