-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backend API] Implement endpoint for view event details #318
[Backend API] Implement endpoint for view event details #318
Conversation
75d851a
to
24abc54
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
코멘트 남겨뒀습니다
Related to: aliencube#208
Related to: aliencube#208
Add codes for handling where the table does not exist Add codes for handling 404 error Related to: aliencube#208
Related to: aliencube#208
Related to: aliencube#208
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
좋습니다! 두어가지만 더 짚어보시지요.
src/AzureOpenAIProxy.ApiApp/Repositories/AdminEventRepository.cs
Outdated
Show resolved
Hide resolved
test/AzureOpenAIProxy.ApiApp.Tests/Services/AdminEventServiceTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
하나만 더!
src/AzureOpenAIProxy.ApiApp/Repositories/AdminEventRepository.cs
Outdated
Show resolved
Hide resolved
Related to: aliencube#208
혹시 테스트코드는 괜찮은지 한 번만 더 봐주실 수 있나요? 익숙치 않아서 조금 자신이 없네요 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다! LGTM!
Resolves: #208
Description
AdminEventEndpoints.cs
의 AddGetAdminEvent 메소드 업데이트AdminEventRepository.cs
업데이트TableServiceClient
의존성 추가GetEvent
메소드 구현AdminEventService.cs
업데이트GetEvent
메소드 구현