Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backend API] Implement endpoint for view event details #318

Conversation

sikutisa
Copy link
Contributor

@sikutisa sikutisa commented Sep 14, 2024

Resolves: #208

Description

  • 이벤트 ID를 통해 이벤트 세부사항을 가져오는 API 구현
  • AdminEventEndpoints.csAddGetAdminEvent 메소드 업데이트
  • AdminEventRepository.cs 업데이트
    • TableServiceClient 의존성 추가
    • GetEvent 메소드 구현
  • AdminEventService.cs 업데이트
    • GetEvent 메소드 구현
  • 변경 사항에 대한 테스트 추가

@sikutisa sikutisa force-pushed the feature/208-Implement-endpoint-for-view-event-details branch 2 times, most recently from 75d851a to 24abc54 Compare September 20, 2024 02:13
Copy link
Contributor

@justinyoo justinyoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코멘트 남겨뒀습니다

Add codes for handling where the table does not exist
Add codes for handling 404 error

Related to: aliencube#208
@sikutisa sikutisa marked this pull request as ready for review September 22, 2024 09:28
Copy link
Contributor

@justinyoo justinyoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋습니다! 두어가지만 더 짚어보시지요.

Copy link
Contributor

@justinyoo justinyoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

하나만 더!

@sikutisa
Copy link
Contributor Author

혹시 테스트코드는 괜찮은지 한 번만 더 봐주실 수 있나요? 익숙치 않아서 조금 자신이 없네요 😅

Copy link
Contributor

@justinyoo justinyoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다! LGTM!

@justinyoo justinyoo merged commit f2dc471 into aliencube:main Sep 23, 2024
1 check passed
@sikutisa sikutisa deleted the feature/208-Implement-endpoint-for-view-event-details branch September 23, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Backend API] Implement endpoint for view event details
2 participants