[Backend API] Implement endpoint for list event details #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praivesi
force-pushed
the
task/218-backend-api-list-events
branch
from
9f9fdec to
8a943d2
Compare
praivesi
force-pushed
the
task/218-backend-api-list-events
branch
from
8a943d2 to
65be6a9
Compare
praivesi
changed the title
|
@praivesi 빌드가 깨집니다. 로컬에서 빌드/테스트 통과했나요? |
justinyoo
requested changes
Oct 3, 2024
Comment on lines
+45
to
+50
| /// <summary> | ||
| /// Deletes the event details. | ||
| /// </summary> | ||
| /// <param name="eventDetails">Event details instance.</param> | ||
| /// <returns>Removed EventID of event details instance.</returns> | ||
| Task<Guid> DeleteEvent(AdminEventDetails eventDetails); |
Comment on lines
+64
to
+68
| var tableClient = _tableServiceClient.GetTableClient(_storageAccountSettings.TableStorage.TableName); | ||
|
|
||
| await tableClient.AddEntityAsync<AdminEventDetails>(eventDetails); | ||
|
|
||
| return eventDetails; |
There was a problem hiding this comment.
이 태스크는 이벤트 리스트 가져오는 거라 이 메소드는 굳이 구현하실 필요가 없습니다.
Comment on lines
+77
to
+80
| await foreach (var entity in tableClient.QueryAsync<AdminEventDetails>()) | ||
| { | ||
| eventDetailsList.Add(entity); | ||
| } |
There was a problem hiding this comment.
테이블에 이벤트 디테일만 들어있는 게 아니라서, 이렇게 하면 에러 날 거예요. 적어도 파티션 키를 넣어줘야 할 겁니다.
Comment on lines
+38
to
+44
|
|
||
| /// <summary> | ||
| /// Deletes the event details. | ||
| /// </summary> | ||
| /// <param name="eventDetails">Event details to update.</param> | ||
| /// <returns>Removed EventID of event details instance.</returns> | ||
| Task<Guid> DeleteEvent(AdminEventDetails eventDetails); |
Comment on lines
+86
to
+92
| /// <inheritdoc /> | ||
| public async Task<Guid> DeleteEvent(AdminEventDetails eventDetails) | ||
| { | ||
| var result = await this._repository.DeleteEvent(eventDetails).ConfigureAwait(false); | ||
|
|
||
| return result; | ||
| } |
Comment on lines
+101
to
+107
| var tableClient = await GetTableClientAsync(); | ||
|
|
||
| eventDetails.EventId = eventId; | ||
|
|
||
| await tableClient.UpdateEntityAsync<AdminEventDetails>(eventDetails, eventDetails.ETag, TableUpdateMode.Replace); | ||
|
|
||
| return eventDetails; |
There was a problem hiding this comment.
마찬가지로 이 태스크의 스코프를 벗어난 구현입니다.
Comment on lines
+110
to
+116
| public async Task<Guid> DeleteEvent(AdminEventDetails eventDetails) | ||
| { | ||
| var tableClient = await GetTableClientAsync(); | ||
|
|
||
| await tableClient.DeleteEntityAsync(eventDetails.PartitionKey, eventDetails.RowKey); | ||
|
|
||
| return eventDetails.EventId; |
Comment on lines
+19
to
+30
| private readonly StorageAccountSettings mockSettings; | ||
| private readonly TableServiceClient mockTableServiceClient; | ||
| private readonly TableClient mockTableClient; | ||
|
|
||
| public AdminEventRepositoryTests() | ||
| { | ||
| mockSettings = Substitute.For<StorageAccountSettings>(); | ||
| mockTableServiceClient = Substitute.For<TableServiceClient>(); | ||
| mockTableClient = Substitute.For<TableClient>(); | ||
|
|
||
| mockTableServiceClient.GetTableClient(Arg.Any<string>()).Returns(mockTableClient); | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업중인 이슈
#218
작업 내용
궁금한 점
AdminEventRepository 클래스의 UpdateEvent() 함수가 EventId 파라미터를 전달 받도록 기존 인터페이스가 작성되어 있었는데,
이 EventId를 꼭 전달해주어야 하는지 궁금합니다.
EventId와 함께 전달되는 AdminEventDetails 객체에 이미 EventId 필드가 있기 때문에 중복되는 것 같기도 해서요.