-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backend API] Implement endpoint for list of deployment models #170 #334
Draft
yjchun626
wants to merge
21
commits into
aliencube:main
Choose a base branch
from
yjchun626:feature/170-deployment-model-list-endpoint
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[Backend API] Implement endpoint for list of deployment models #170 #334
yjchun626
wants to merge
21
commits into
aliencube:main
from
yjchun626:feature/170-deployment-model-list-endpoint
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
그에 따른 PlaygroundService.cs - GetDeploymentModels 업데이트
아무래도 RDB를 쓰는게 아니다보니 각 개체들 관계가 명확하지 않아요. 현재 public class EventDetails : ITableEntity
{
...
public List<Guid> Resources { get; set; } = [];
...
} 이렇게 해 두면 특정 |
|
…proxy into feature/170-deployment-model-list-endpoint
GetDeploymentModels() 메소드 NotImplementedException 처리(임시)
eventId Arrange 시 String -> Guid로 수정
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈
변경 사항
PlaygroundEndpoints.cs
-AddListDeploymentModels
구현PlaygroundService.cs
,EventRepository.cs
추가EventRepository.cs
에GetDeploymentModels
Task를 추가했습니다.궁금한 점
/events/{eventId}/deployment-models
로 되어있어서 우선은 특정 event에eventId
로 접근을 하고, 그 event에 허용된 deployment model의 리스트를 가져오는 절차라고 대략 생각하고 있었습니다.EventDetail
등 세부적인 관계가 어떻게 되는지에 대해 정확히 파악하지 못해서, repository 계층에서GetDeploymentModels
메소드를 구체적으로 어떻게 구현해야 하는지 잘 모르겠습니다.GetDeploymentModels
를 구현할 때EventRepository.cs
가 아닌 다른 개별 파일을 만드는 것이 좋을까요?eventId
로 개별 이벤트를 조회한 다음에, 그 이벤트에서 사용가능한 deployment model의 list를 가져오는 것을 어떻게 해야 하는지 아직 감을 못 잡은 상태입니다.infra/scripts/New-OpenAIs.ps1
등의 파일에서 다음과 같은 코드들을 발견하긴 했는데, 그러면 Azure 상의 특정 위치에 직접 접근을 해서 가져오는 방식인 것인지... 등을 여쭙고 싶습니다.