Skip to content

Commit

Permalink
Fix broken shaping on macOS (Core Text)
Browse files Browse the repository at this point in the history
Apparently OTL must include Arabic script or Arabic shaping will not
happen.
  • Loading branch information
khaledhosny committed Mar 19, 2020
1 parent 2b3bf24 commit a16ce4b
Show file tree
Hide file tree
Showing 4 changed files with 39 additions and 6 deletions.
2 changes: 1 addition & 1 deletion Qahiri-Regular.fea
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
@DotsBelow = [dotbelow-ar dotbelow-ar.alt1 twodotshorizontalbelow-ar twodotshorizontalbelow-ar.alt1];
@TwoDotsBelow = [ twodotshorizontalbelow-ar twodotshorizontalbelow-ar.alt1];
languagesystem DFLT dflt;

languagesystem arab dflt;
lookup AboveHah {
sub behDotless-ar.init by behDotless-ar.init.hah;
sub lam-ar.init by lam-ar.init.hah;
Expand Down
Binary file modified Qahiri-Regular.otf
Binary file not shown.
40 changes: 37 additions & 3 deletions Qahiri-Regular.ttx
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@
<!-- Most of this table will be recalculated by the compiler -->
<tableVersion value="1.0"/>
<fontRevision value="1.004"/>
<checkSumAdjustment value="0x7eb78568"/>
<checkSumAdjustment value="0x84e97350"/>
<magicNumber value="0x5f0f3cf5"/>
<flags value="00000000 00000011"/>
<unitsPerEm value="750"/>
Expand Down Expand Up @@ -5288,7 +5288,7 @@ You should have received a copy of the GNU Affero General Public License along w
<GPOS>
<Version value="0x00010000"/>
<ScriptList>
<!-- ScriptCount=1 -->
<!-- ScriptCount=2 -->
<ScriptRecord index="0">
<ScriptTag value="DFLT"/>
<Script>
Expand All @@ -5302,6 +5302,19 @@ You should have received a copy of the GNU Affero General Public License along w
<!-- LangSysCount=0 -->
</Script>
</ScriptRecord>
<ScriptRecord index="1">
<ScriptTag value="arab"/>
<Script>
<DefaultLangSys>
<ReqFeatureIndex value="65535"/>
<!-- FeatureCount=3 -->
<FeatureIndex index="0" value="0"/>
<FeatureIndex index="1" value="1"/>
<FeatureIndex index="2" value="2"/>
</DefaultLangSys>
<!-- LangSysCount=0 -->
</Script>
</ScriptRecord>
</ScriptList>
<FeatureList>
<!-- FeatureCount=3 -->
Expand Down Expand Up @@ -13915,7 +13928,7 @@ You should have received a copy of the GNU Affero General Public License along w
<GSUB>
<Version value="0x00010000"/>
<ScriptList>
<!-- ScriptCount=1 -->
<!-- ScriptCount=2 -->
<ScriptRecord index="0">
<ScriptTag value="DFLT"/>
<Script>
Expand All @@ -13937,6 +13950,27 @@ You should have received a copy of the GNU Affero General Public License along w
<!-- LangSysCount=0 -->
</Script>
</ScriptRecord>
<ScriptRecord index="1">
<ScriptTag value="arab"/>
<Script>
<DefaultLangSys>
<ReqFeatureIndex value="65535"/>
<!-- FeatureCount=11 -->
<FeatureIndex index="0" value="0"/>
<FeatureIndex index="1" value="1"/>
<FeatureIndex index="2" value="2"/>
<FeatureIndex index="3" value="3"/>
<FeatureIndex index="4" value="4"/>
<FeatureIndex index="5" value="5"/>
<FeatureIndex index="6" value="6"/>
<FeatureIndex index="7" value="7"/>
<FeatureIndex index="8" value="8"/>
<FeatureIndex index="9" value="9"/>
<FeatureIndex index="10" value="10"/>
</DefaultLangSys>
<!-- LangSysCount=0 -->
</Script>
</ScriptRecord>
</ScriptList>
<FeatureList>
<!-- FeatureCount=11 -->
Expand Down
3 changes: 1 addition & 2 deletions Qahiri.glyphs
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,8 @@ designerURL = "https://github.com/alif-type";
familyName = Qahiri;
featurePrefixes = (
{
automatic = 1;
code = "languagesystem DFLT dflt;
";
languagesystem arab dflt;";
name = Languagesystems;
},
{
Expand Down

0 comments on commit a16ce4b

Please sign in to comment.