Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor cleanup #1074

Merged
merged 7 commits into from
Oct 17, 2023
Merged

Minor cleanup #1074

merged 7 commits into from
Oct 17, 2023

Conversation

gowrizrh
Copy link
Contributor

@gowrizrh gowrizrh commented Sep 29, 2023 •
edited
Loading

Description of the proposed changes

  • Remove unused test
  • Remove any type definition
  • Change prepublish command from tsc to npm run build
  • Add @aligent/esbuild as a dependency to packages that use it.

@gowrizrh gowrizrh marked this pull request as ready for review September 29, 2023 04:32
TheOrangePuff
TheOrangePuff previously approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@TheOrangePuff TheOrangePuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

TheOrangePuff
TheOrangePuff reviewed Oct 5, 2023
View reviewed changes
Copy link
Contributor

@TheOrangePuff TheOrangePuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple questions

packages/prerender-proxy/package.json Show resolved Hide resolved
tsconfig.json Show resolved Hide resolved
@TheOrangePuff TheOrangePuff merged commit e6c9b4e into epic/cdk-v2 Oct 17, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheOrangePuff TheOrangePuff TheOrangePuff approved these changes

@AdamJHall AdamJHall Awaiting requested review from AdamJHall

@krishanthisera krishanthisera Awaiting requested review from krishanthisera

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gowrizrh @TheOrangePuff