Improve compatibility with IOS 8 #157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avoids _objc_unsafeClaimAutoreleasedReturnValue error in xcode 8 when launching older versions of IOS
hmedney
changed the title
Owner
|
@hmedney I made it though by accident. Good catch, let's get this one in. I'm working on v2 branch so, everything there are experimental so for now don't bother look into it until I make a PR. |
|
have you update this chage to npm ? |
|
@alinz can you please push this to npm? Causing serious errors on our app in iOS 8 |
|
@alinz please publish this new commit to npm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi @alinz, proposing a change to the xcode build settings to set the IOS Deployment target to 8.0. This aligns with the RN project template and the supported IOS versions in RN (8.0+). The previous deployment target was 9.1, and I wanted to see if you had a reason for that value before changing.
Reason for change was apps using the webview bridge in IOS 8.x simulators in XCode 8 would hard crash with a
_objc_unsafeClaimAutoreleasedReturnValueerror. Per this SO post, this can happen if a sub-project has a deploy target higher than the parent project.