Skip to content

Commit

Permalink
Document index breaking change (git+https)
Browse files Browse the repository at this point in the history
  • Loading branch information
mosteo committed Jan 21, 2025
1 parent 3d280a5 commit 685f1f3
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
6 changes: 5 additions & 1 deletion BREAKING.md
Original file line number Diff line number Diff line change
@@ -1,10 +1,14 @@
Log of breaking changes in index or alr.

### alr 3.0.0 + index 1.3.0
### alr 3.0.0 + index 1.4.0

- alr: removed `ALR_CONFIG` environment variable.
- alr: removed `alr config` command.

### alr 2.1.0 + index 1.4.0

- index: git remotes in origins are recognized even without `git+` prefix

### alr 2.0.0 + index 1.3.0

- index:`binary` property required in binary origins.
Expand Down

3 comments on commit 685f1f3

@Seb-MCaw
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the ada-toml revert intentional, @mosteo? The submodule no longer uses the same version as the pin in alire.toml.

Sorry for not anticipating that #1736 would be a breaking change to the index; I'll open a PR to change Alire.URI.Make_VCS_Explicit to always add a git+, even if there is a .git suffix, so that alr publish produces backwards-compatible manifests.

@mosteo
Copy link
Member Author

@mosteo mosteo commented on 685f1f3 Jan 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, not intentional. I thought I only had edited the README! That's what happens for getting cocky and not going through a PR...

Yes, I think it's better if we keep on generating backwards-compatible manifests, this will save us some headaches.

@mosteo
Copy link
Member Author

@mosteo mosteo commented on 685f1f3 Jan 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW I'll fix the ada_toml issue.

Please sign in to comment.