Fix unpacking of tarfiles with softlinks to subdirectories #1382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remains: GC.VFS.Remove_Dir fails because of the same reason, probably.
Otherwise, depending on the links' targets, both Ada.Directories and GNATCOLL.VFS had trouble with fully deleting a tree containing such links.
Fabien-Chouteau
approved these changes
May 31, 2023
The tarfile for gcc13 that I've been using (the one from Maxim IIRC) contains a softlink from a parent directory to a child one, something like: parent/bits --> parent/x86_64/bits And our current tree remover is unable to remove that. Also, the contents of "parent/bits" are visited without "parent/bits" itself being ever visited (because it's a softlink), and that confuses the copy process. It's a safeguard in our side, but the ideal situation would be that no softlinks existed in the tarfile. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this is impossible to install e.g. gcc 13.