Bits from the alr share feat to be kept
#1399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fabien-Chouteau
approved these changes
Jul 4, 2023
src/alire/alire-config-edit.adb
Outdated
| @@ -17,6 +17,10 @@ package body Alire.Config.Edit is | |||
| type String_Access is access String; | |||
| Config_Path : String_Access; | |||
|
|
|||
| -- Separately loaded configs to be able to ascertain where a config value | |||
| -- is coming from. | |||
| Level_DB : array (Level) of CLIC.Config.Instance; | |||
There was a problem hiding this comment.
So there are 3 DBs now this one and the two here? It seems overkill.
There's an origin field for every config value, we might be able to use that. Or we remove the common DB and only use the Level_DB with a getter function that will first look in local then global.
There was a problem hiding this comment.
I see, I had not seen the origin field. Will try to use that.
Fabien-Chouteau
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactorings and a few minor bits that will come in handy later on