Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: minor issues with dynamic properties #1887

Merged
merged 13 commits into from
Mar 19, 2025

Conversation

mosteo
Copy link
Member

@mosteo mosteo commented Mar 10, 2025

I identified these deficiencies while reviewing #1881:

  • We weren't preventing case expressions for properties that shouldn't allow them.
  • We were checking cardinality of properties only for a subset of properties (those implemented as 'labeled').
  • Export of the new [test] property would fail if containing dynamic expressions.
PR creation checklist
  • A test is included, if required by the changes.

@mosteo mosteo force-pushed the fix/dynamic-properties branch from 72077ff to 96d773a Compare March 10, 2025 23:19
@mosteo mosteo marked this pull request as ready for review March 11, 2025 15:57
@mosteo mosteo requested a review from Fabien-Chouteau March 11, 2025 15:57
@mosteo mosteo force-pushed the fix/dynamic-properties branch from e2a2a07 to c401a5a Compare March 19, 2025 16:11
@mosteo
Copy link
Member Author

mosteo commented Mar 19, 2025

Addressed review by @AldanTanneo

@mosteo mosteo merged commit 71e371d into alire-project:master Mar 19, 2025
34 checks passed
@mosteo mosteo deleted the fix/dynamic-properties branch March 19, 2025 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants