Incrementally edit manifest on alr with
#484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
54 tasks
mosteo
force-pushed
the
feat/append
branch
3 times, most recently
from
4bf24de to
0f4bac8
Compare
Fabien-Chouteau
requested changes
Jul 31, 2020
Fabien-Chouteau
approved these changes
Jul 31, 2020
mosteo
force-pushed
the
feat/separate-origins
branch
from
3cb3d3f to
5e92a6c
Compare
This action will also not touch lines that aren't involved in the deletion. Only a simple dependency, and trivially empty [[depends-on]] array entries will be removed. As an improvement over the previous situation, dynamic expressions will not preclude using `alr with` for static dependencies, leaving the dynamic ones untouched.
This was happening before by chance in several tests. The `alr with` changes have surfaced that the order on file is kept in tree; while this has no secondary effects, for presentation to the user is better to be always consistent. Solutions already use ordered sets, so for lists within conditional trees we do the same (only for presentation).
mosteo
added a commit
that referenced
this pull request
Sep 1, 2020
* Append new dependencies to the end of the manifest * Conservative removal of dependencies in `alr with` This action will also not touch lines that aren't involved in the deletion. Only a simple dependency, and trivially empty [[depends-on]] array entries will be removed. As an improvement over the previous situation, dynamic expressions will not preclude using `alr with` for static dependencies, leaving the dynamic ones untouched. * Use lexicographical order for printing dependencies This was happening before by chance in several tests. The `alr with` changes have surfaced that the order on file is kept in tree; while this has no secondary effects, for presentation to the user is better to be always consistent. Solutions already use ordered sets, so for lists within conditional trees we do the same (only for presentation). * Testsuite minor output fix * Tests for new removal of dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the change described in #466 in which
alr withdoesn't regenerate the whole manifest but only appends new dependencies at the end.Adding dependencies is trivial; removal is allowed for static dependencies (the kind that can be added via
alr withanyway) and will fail for a dynamic dependency introduced manually or any other unforeseen circumstance. Still, dynamic and static dependencies can now coexist in a manifest andalr withwill not complain, unlike before where a single dynamic dependency would precludealr withfrom working anymore (the manifest could not be regenerated).Along the way, this PR introduces a couple of supporting types to allow safe editing of the manifest, in the sense that any error while adding/removing dependencies to the manifest will preserve the original manifest, untouched, just in case.
Also, the changes surfaced the circumstance that solved dependencies are always shown in alphabetical order, whereas direct unsolved dependencies were shown in their loading order. The latter have been fixed for consistency.