Incremental building of dependencies #832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yes that's a better option because the libraries can be compiled for different targets and Alire doesn't know that. |
mosteo
force-pushed
the
feat/incremental-build
branch
from
1cf1f3a to
4b4aead
Compare
And minor bug in which the code as improperly assumed to be positive
Fabien-Chouteau
approved these changes
Sep 9, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #628
For context: we want to build dependencies in a safe order, so tools built by a dependency become available down the building chain.
@Fabien-Chouteau , this is istill work in progress, but I've hit a situation. When trying to build
shoot_n_lootwith this patch, it fails because it tries to build the project files insamd51_hal. My question would be if this is a problem with our current idea, or with some crate configuration.Right now, the feature works by trying to build all project files in dependencies that have
auto_gpr_withenabled. Perhaps we could restrict it further to crates explicitly declaring executables?